Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add profilerrpc #10

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

FrankYang0529
Copy link
Contributor

Which issue(s) this PR fixes:

longhorn/longhorn#6744

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

Signed-off-by: PoAn Yang <yangpoan@gmail.com>
Copy link

@Vicente-Cheng Vicente-Cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Checked the protobuf/profilerrpc/profilerrpc.proto and scripts/generate_grpc.
Others look like generated files.

@innobead innobead merged commit ef450e1 into longhorn:main Jun 5, 2024
2 checks passed
@FrankYang0529 FrankYang0529 deleted the add-profilerrpc branch June 5, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants